feat(fs5.5): add display connector activation proofs#61
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughThis PR adds explicit connector-targeted activation support to the virtio-gpu display system. It introduces new APIs for selecting and activating specific display connectors at runtime, extends the request parsing and service handling layers, and validates the activation behavior through enhanced display probe checks across multiple component layers. Changes
Sequence DiagramsequenceDiagram
participant Client as Client/TCP
participant Service as tool_service
participant Codec as codec
participant Exec as tool_exec
participant Output as display_output
Client->>Service: DISPLAYACTIVATE {connector}
Service->>Codec: Parse framed request
Codec->>Codec: Recognize DISPLAYACTIVATE opcode
Codec-->>Service: Return operation.display_activate = connector_name
Service->>Exec: activateDisplayConnector(connector_type)
Exec->>Output: selectOutputConnector(connector_type)
Output->>Output: Iterate entries for matching connected connector
alt Connector found
Output->>Output: Mutate state fields (scanout, resolution, etc.)
Output-->>Exec: return true
Exec-->>Service: Success
else Connector not found
Output-->>Exec: return false
Exec-->>Service: DisplayConnectorMismatch error
end
Service->>Output: statePtr() to build response
Service-->>Client: DISPLAYACTIVATE {connector} scanout=X current=WxH or ERR response
Possibly Related PRs
Poem
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
Summary by CodeRabbit
New Features
display-activate <connector>command.Documentation